[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH updated] Support for filesystem watching (inotify)

From: Paul Eggert
Subject: Re: [PATCH updated] Support for filesystem watching (inotify)
Date: Wed, 06 Jul 2011 08:54:28 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10

On 07/06/11 06:36, Stefan Monnier wrote:

> My preference would be to wait for 24.2 since we're in feature freeze,
> but it's the kind of feature which benefits from being available early
> so other packages can start using it.  WDYT?

I briefly looked at it for integer-overflow issues, and found one: it
assumes that inotify cookies fit into an Emacs fixnum.  This assumption
isn't true on 32-bit hosts, unless Emacs is configured with
--with-wide-int.  As you know I'm a fan of wide integers, and my preferred
solution would be to make --with-wide-int the default, which would solve
the problem.  As that is also being considered for 24.2, perhaps the
inotify feature should wait for 24.2 as well.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]