[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH updated] Support for filesystem watching (inotify)

From: Stefan Monnier
Subject: Re: [PATCH updated] Support for filesystem watching (inotify)
Date: Wed, 06 Jul 2011 14:30:10 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

>> My preference would be to wait for 24.2 since we're in feature freeze,
>> but it's the kind of feature which benefits from being available early
>> so other packages can start using it.  WDYT?
> I briefly looked at it for integer-overflow issues, and found one: it
> assumes that inotify cookies fit into an Emacs fixnum.

Thanks.  This needs to be fixed, indeed.

> This assumption isn't true on 32-bit hosts, unless Emacs is configured
> with --with-wide-int.  As you know I'm a fan of wide integers, and my
> preferred solution would be to make --with-wide-int the default, which
> would solve the problem.

No, that would only solve the problem if the --with-wide-int option is
removed on 32bit systems and imposed as the only choice.  Even if we may
change the default for 24.2 we're definitely not going to drop support
for "narrow int" operation so soon.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]