[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] system-type cygwin with window-system w32

From: Paul Eggert
Subject: Re: [PATCH] system-type cygwin with window-system w32
Date: Mon, 18 Jul 2011 09:13:36 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11

I have qualms about this part of the patch, in lisp.h:

+#define t(...)                                          \
+    ({                                                  \
+      fprintf (stderr, "T:%s:%u: ",                     \
+               __FUNCTION__, __LINE__);                 \
+      fprintf (stderr, __VA_ARGS__);                    \
+      fputc ('\n', stderr);                             \
+    })

Is this some sort of test scaffolding that is intended to be
removed before the patch actually goes in?  If not, it has
some problems.  The name "t" is too short and cryptic.
The ({...}} construction is not standard C and won't work
with many non-GCC compilers.  The __FUNCTION__ macro is also

reply via email to

[Prev in Thread] Current Thread [Next in Thread]