[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] notifications.el: fixed image-data and image-path hints pass
From: |
Mike Kazantsev |
Subject: |
Re: [PATCH] notifications.el: fixed image-data and image-path hints passing |
Date: |
Mon, 7 Nov 2011 14:35:32 +0600 |
On Mon, 7 Nov 2011 14:29:11 +0600
Mike Kazantsev <address@hidden> wrote:
> On Mon, 7 Nov 2011 14:22:30 +0600
> Mike Kazantsev <address@hidden> wrote:
>
> >
> > Good day,
> >
> > Before the patch, hints were passed as "image_path" and "image_data",
> > which is incorrect, as Desktop Notifications Specification v1.2 clearly
> > states:
> >
> > The icon is defined by the "app_icon" parameter. The image can be
> > defined by the "image-path", the "image-data" hint or the deprecated
> > "icon_data" hint.
> >
> > Most common (by far) implementation of spec - libnotify - seem to pass
> > them as described in spec as well, so current behavior looks like a bug.
> >
>
> Actually looking at previous spec versions (which can be found on
> http://www.galago-project.org/specs/notification/), there seemed to be
> an "icon_data" hint in 0.9, but not "icon_path", so I can guess that's
> where these came from.
>
> Mentioned specs seem to be fairly obsolete now, and even if they
> should be supported, there doesn't seem to be any excuse to pass
> "icon_path".
>
Hmm... and looking further at 1.1, which is mentioned a bit below in
the code, and even set as "notifications-specification-version", I see
that current implementation is actually correct.
Terribly sorry for the confusion and the noise, should've checked the
specs more closely.
Desktop Notifications Specification 1.1:
http://people.gnome.org/~mccann/docs/notification-spec/notification-spec-1.1.html
P.S. Link to galago-project.org at the top of the module seem to be
bogus though - specs there only cover versions up to 0.9, but I guess
it's not worth a separate fix.
>
> > Patch to pass "image-path" and "image-data" hints - as per spec - is
> > attached below.
> >
> > Desktop Notifications Specification:
> >
> > http://developer.gnome.org/notification-spec/#icons-and-images
> >
> > http://people.gnome.org/~mccann/docs/notification-spec/notification-spec-latest.html#icons-and-images
> >
> ...
>
>
--
Mike Kazantsev // fraggod.net
signature.asc
Description: PGP signature