[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] Compilation cleanups
From: |
Paul Eggert |
Subject: |
Re: [PATCH 1/4] Compilation cleanups |
Date: |
Thu, 29 Dec 2011 09:54:19 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111124 Thunderbird/8.0 |
On 12/29/11 06:03, Daniel Colascione wrote:
> --- a/lib-src/update-game-score.c
> +++ b/lib-src/update-game-score.c
> @@ -48,8 +48,10 @@ along with GNU Emacs. If not, see
> <http://www.gnu.org/licenses/>. */
> #include <sys/stat.h>
>
> /* Needed for SunOS4, for instance. */
> +#if !defined(CYGWIN)
> extern char *optarg;
> extern int optind, opterr;
> +#endif // !defined(CYGWIN)
I suggest replacing those lines with "#include <getopt.h>" instead;
that's what the other .c files do, and it's cleaner.
> --- a/src/gmalloc.c
> +++ b/src/gmalloc.c
...
> - if (ptr < _heapbase)
> + if ((char*)ptr < (char*)_heapbase)
No need to cast _heapbase as it's already a char *.
And please put a space after the ')', e.g.,
"(char*) ptr < _heapbase", as that's the usual
Emacs style.
Re: [PATCH 4/4] Fix emacsclient to work with cygw32, Eli Zaretskii, 2011/12/29