Re: [PATCH 4/4] Fix emacsclient to work with cygw32

[Juanma Barranquero]

On Thu, Dec 29, 2011 at 19:18, Eli Zaretskii <address@hidden> wrote:

> But the ifdef-out must stay in the native w32 build, I think, because
> it causes trouble further down the line.  Juanma, can you comment,
> please?

>From a cursory look and a full five-minute test, I'd say that, in a
GUI Emacs server it will cause no harm.

When the Emacs server instance is running in a console, "emacsclient
-d zzz myfile" will affect deletion of the frame after C-x #. I don't
think it'd be hard to fix, but you know how *much* I love fiddling
with emacsclient's #ifdefs and flags. Couldn't think of a better
Christmas gift for myself.

Also, offering the user an option which does nothing is ugly. So I'd
vote for #ifdef'ing it away as it is now and sparing us some trouble
and testing.

    Juanma