[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] add "underwave" face attribute

From: Leo
Subject: Re: [patch] add "underwave" face attribute
Date: Fri, 27 Jan 2012 12:01:33 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (Mac OS X 10.6.8)

On 2012-01-27 01:55 +0800, Aurélien Aptel wrote:
> I implemented a new face attribute "underwave". It does exactly what
> this thread[1] asked for.
> It only works on X11 currently. I don't have a windows/mac machine to
> port this feature but it should be easy to do: just port the changes
> made to xterm.c to other *term.c. I've basically followed whatever
> "overline" was doing so it should be ok.

Thank you for taking the trouble to implement it. Looks nice.

> I've attached the diff and a screenshot of the splash screen with the
> default and link face changed to use underwaving. Note that it looks
> good on both X11 core fonts and Xft fonts.
> I would love to this this merged in emacs so -- if everything's
> alright -- what's the next step?

Probably submit the patch to the bug tracker M-x report-emacs-bug. Get
someone to review it.

Thanks again.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]