Re: Patch for PHP5 support for etags

[Olivier Sirven]

Hi,

On 2012-03-08 20:10:25, Francesco Potortì wrote:
>>On 2012-02-24 11:36:06, Olivier Sirven wrote:
>>> On 2011-04-26 14:36:35, Lennart Borgman wrote:
>>>> On Tue, Apr 26, 2011 at 2:25 PM, Francesco Potortì <address@hidden> wrote:
>>>>>
>>>>> Yes, I applied the patch.  I tested it and got strange results.  So I
>>>>> need a php5 source file together with the expected results, so that I
>>>>> can check it with more confidence.  Can you provide that, or point me to
>>>>> someone else who can?
>>>>
>>>> Maybe some of those that have contributed to php-mode.el can?
>>>
>>> I'm no php-mode.el contributor but I do code in PHP5 every single
>>> working day using emacs for a long time now. 
>>> I was previously forcing language detection to java in order to have
>>> something usable even though not perfect.
>>>
>>> I've just found out about this PHP5 patch for etags and just gave it a
>>> try. As far as I can see it works just fine, all my declarations are
>>> there and I don't see any strange results.
>>>
>>> If you need any help getting this into the main code base I'd be glad to
>>> help. But first I need to understand what you mean by "strange results"
>>> so I can check whether or not I do have the same issue
>
> Ok, I must have lost this mail of yours, at least I cannot find it in my
> records.  Sorry about that.  That said, I am lagging behind with work on
> etags.  Much, much behind.  And yes, if some other maintainer steps in
> to volunteer, I will pass the baton.
>
> Today I tried to recompile etags locally for the first time in a couple
> years at least and I am seeing some problems (etags should be able to
> compile even outside of the Emacs tree).

,----[ make etags ]
| $ make etags
| gcc -std=gnu99   -Wimplicit-function-declaration -Wold-style-definition 
-Wdeclaration-after-statement  -DHAVE_CONFIG_H -I. -I../src -I../lib 
-I/home/slaanesh/src/emacs/trunk/lib-src 
-I/home/slaanesh/src/emacs/trunk/lib-src/../src 
-I/home/slaanesh/src/emacs/trunk/lib-src/../lib    -g -O2 -DEMACS_NAME="\"GNU 
Emacs\"" \
|         -DVERSION="\"24.0.94\"" 
/home/slaanesh/src/emacs/trunk/lib-src/etags.c \
|         regex.o ../lib/libgnu.a  -o etags
| /tmp/cceEvudD.o: In function `main':
| /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1191: undefined reference to 
`rpl_optarg'
| /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1166: undefined reference to 
`rpl_optarg'
| /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1166: undefined reference to 
`rpl_optarg'
| /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1170: undefined reference to 
`rpl_optarg'
| /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1147: undefined reference to 
`rpl_optarg'
| /tmp/cceEvudD.o:/home/slaanesh/src/emacs/trunk/lib-src/etags.c:1114: more 
undefined references to `rpl_optarg' follow
| /tmp/cceEvudD.o: In function `main':
| /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1208: undefined reference to 
`rpl_optind'
| /home/slaanesh/src/emacs/trunk/lib-src/etags.c:1208: undefined reference to 
`rpl_optind'
| ../lib/libgnu.a(getopt1.o): In function `rpl_getopt_long':
| /home/slaanesh/src/emacs/trunk/lib/getopt1.c:43: undefined reference to 
`rpl_getopt_internal'
| ../lib/libgnu.a(getopt1.o): In function `rpl_getopt_long_only':
| /home/slaanesh/src/emacs/trunk/lib/getopt1.c:66: undefined reference to 
`rpl_getopt_internal'
| collect2: ld returned 1 exit status
| make: *** [etags] Error 1
`----

it seems etags compilation is broken even in the emacs tree (using a
up-to-date bzr tree). Am I doing something wrong here?

>>I see nobody has interest into PHP5 for etags...so sad!
>>
>>So maybe I'm the only one but what can/should I do to get this patch
>>merged?
>
> If you would like to try, you are welcome!  As a start, please try and
> start from the current etags.c version in Emacs trunk.  Then write to
> me, I'll try to help you get going, if necessary.
>
> Else, I'll try to reapply the patch and see what comes out.

Would be my pleasure to do it for sure :)

-- 
Oliv