[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: CHAR_TO_BYTE in bidi_resolve_explicit_1
From: |
Eli Zaretskii |
Subject: |
Re: CHAR_TO_BYTE in bidi_resolve_explicit_1 |
Date: |
Tue, 05 Mar 2013 20:14:46 +0200 |
> Date: Tue, 05 Mar 2013 13:30:06 +0400
> From: Dmitry Antipov <address@hidden>
> CC: address@hidden
>
> On 03/05/2013 07:51 AM, Eli Zaretskii wrote:
>
> > We could use BEGV_BYTE when we limit charpos to BEGV, yes. But
> > otherwise, the call to CHAR_TO_BYTE is not redundant, because nothing
> > else makes sure bidi_it->charpos is synchronized with bidi_it->bytepos
> > when the display engine re-seats the display iterator.
>
> AFAICS reseat routines uses bidi_init_it to make sure that BIDI stuff
> is synced with the rest of redisplay, isn't it?
Actually, I see that you are right. I was speaking from my failing
memory of a situation that has long since changed.
So I installed a slightly more radical change than the one you
suggested. Thanks.