[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cl-defstruct-based package.el, now with ert tests!

From: Tom Tromey
Subject: Re: cl-defstruct-based package.el, now with ert tests!
Date: Mon, 11 Mar 2013 20:01:57 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Daniel> My aim has been to clean up package.el, primarily by using
Daniel> `cl-defstruct' to create a `package-desc' structure which is
Daniel> used throughout the library.

This sounds good.

Daniel> The changes touch most of the code, but the overall structure of the
Daniel> code has not changed significantly. Some parts of the code which were
Daniel> questionable in the first place (such as using `tar-mode' to extract tar
Daniel> archives) have been replaced with simpler alternatives. In the case of
Daniel> tar, the file is simply downloaded to a temporary directory and
Daniel> extracted using "tar xaf foo-1.2.3.tar".

This sounds worse to me, since it means that now package installation
has an external dependency.  Previously this was not the case --


reply via email to

[Prev in Thread] Current Thread [Next in Thread]