[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Build failure from trunk
From: |
Paul Eggert |
Subject: |
Re: Build failure from trunk |
Date: |
Wed, 08 May 2013 07:46:50 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5 |
On 05/07/2013 10:06 PM, Jan Djärv wrote:
> #if !defined USE_GTK || GTK_MAJOR_VERSION < 3 + (GTK_MINOR_VERSION < 4)
>
> This will be true for Gtk 4.0 to 4.3, 5.0 to 5.3, 6.0 to 6.3 and so on, so it
> is obviously not correct.
Sorry, I don't see the bug. Perhaps you misread the "+" as "|"?
For 4.0, for example, GTK_MAJOR_VERSION is 4 and GTK_MINOR_VERSION is 0,
so the comparison evaluates to 4 < 3 + (0 < 4),
which is false, which is what is wanted here.
- Build failure from trunk, Matthew Leach, 2013/05/07
- Re: Build failure from trunk, Jan Djärv, 2013/05/07
- Re: Build failure from trunk, Paul Eggert, 2013/05/07
- Re: Build failure from trunk, Jan Djärv, 2013/05/08
- Re: Build failure from trunk,
Paul Eggert <=
- Re: Build failure from trunk, Jan Djärv, 2013/05/08
- Re: Build failure from trunk, Paul Eggert, 2013/05/08
- Re: Build failure from trunk, Jan Djärv, 2013/05/09
- Re: Build failure from trunk, Paul Eggert, 2013/05/09
- Re: Build failure from trunk, Jan Djärv, 2013/05/09