Re: patches and one bug

[Lars Magne Ingebrigtsen]

Ivan Kanis <address@hidden> writes:

> emacs-wget fetches a file with wget asynchronously. It pops a small
> window with the progress of the download.

I don't see the point -- Emacs is perfectly able to download stuff
asynchronously itself.

> -    (setq url (concat eww-search-prefix
> -                      (replace-regexp-in-string " " "+" url))))
> +    (unless (string-match-p "^file:" url)
> +      (setq url (concat eww-search-prefix
> +                        (replace-regexp-in-string " " "+" url)))))

Applied.

> Subject: [PATCH 2/7] handle quoted charset header

Applied.

> Subject: [PATCH 3/7] key 'y' puts page url in kill ring

Applied.

> Subject: [PATCH 4/7] tack / at the end of naked url


[...]

> +  (and (string-match "https*://\\(.*\\)" url)
> +       ;; true when url part is just a hostname
> +       (not (string-match "/" (substring url (match-beginning 1)
> +                                         (match-end 1))))
> +       ;; Last character is not /
> +       (not (string= (substring url (1- (length url)) (length url)) "/"))
> +       ;; tack / at the end of naked url
> +       ;; ie: http://google.com -> http://google.com/
> +       (setq url ( concat url "/")))
>    (url-retrieve url 'eww-render (list url)))

First of all, use `url-generic-parse-url' to parse an URL instead of
using regexps.  Second of all, I don't really see the point.  We'll get
a redirect, anyway.

> Subject: [PATCH 5/7] add optional argument needed for browse url

[...]

> -(defun eww (url)
> -  "Fetch URL and render the page."
> +(defun eww (url &optional new-session interactive-p)
> +  "Fetch URL and render the page.
> +NEW-SESSION and INTERCATIVE-P are not used"

No, just use `url-browse-url' instead.

> Subject: [PATCH 6/7] add emacs-wget

[...]

> +(defun shr-wget ()
> +  "Download URL under point."
> +  (interactive)
> +  (when (not (fboundp 'wget-api))
> +    (error "You need to install emacs-wget."))

Downloading the URL under point is fine, but just use `url-retrieve'.

> Subject: [PATCH 7/7] C-u RET opens link in external browser

Applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/