Re: [Emacs-diffs] trunk r113747: lisp/frameset.el: Convert `frameset' to vector and add new slots.

[Stefan Monnier]

>  - `frameset-save', the type's constructor, captures all or a subset of the
>    live frames, and returns a serializable snapshot of them (a frameset).
> The reason I didn't completely remove make-frameset is because I use
> internally.  It's a tiny bit cleaner that constructing the vector by
> hand.

You could make it more clearly internal by renaming it to something like
frameset--super-dangerous-constructor-do-not-use.

You could also replace it with a constructor that does the right thing.
Something like

   (:constructor nil)
   (:constructor
    frameset-make
    (frame-list &key app name description
                     filters predicate properties
                &aux (states
                      (let* ((list (or (copy-sequence frame-list)
                                       (frame-list)))
                             (frames (cl-delete-if-not
                                      #'frame-live-p
                                      (if predicate
                                          (cl-delete-if-not predicate list)
                                        list))))
                        (frameset--record-minibuffer-relationships frames)
                        (mapcar
                         (lambda (frame)
                           (cons
                            (frameset-filter-params (frame-parameters frame)
                                                    (or filters
                                                        frameset-filter-alist)
                                                    t)
                            (window-state-get (frame-root-window frame) t)))
                         frames)))))

But I find this way really hideous.

> Also, I've added docstrings for frameset-p and all slot accessors, via
> (put 'frameset-SLOT 'function-documentation "Docstring."). Oh the joy.
> Please tell me that I just missed a way to define the docstrings in
> the cl-defstruct declaration...

No, I don't think there's such a thing as slot-doc-strings ;-)
Neither in cl-defstruct, nor in Common-Lisp itself.


        Stefan