[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: trunk r113804: * decompress.c: Fix bugs with large buffers and weird
From: |
Lars Magne Ingebrigtsen |
Subject: |
Re: trunk r113804: * decompress.c: Fix bugs with large buffers and weird inputs. |
Date: |
Tue, 13 Aug 2013 17:10:29 +0200 |
User-agent: |
Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) |
Paul Eggert <address@hidden> writes:
> Lars Magne Ingebrigtsen wrote:
>> Does Emacs compile on any systems
>> where UINT_MAX is smaller than 16384?
>
> No, that code was just trying to remind the reader that
> the value cannot exceed UINT_MAX due to zlib constraints.
> I redid the code and comment a bit to try to make this clearer,
> in trunk bzr 113845.
I think writing 1 << 14 and then checking whether that's larger than
UINT_MAX is still pretty unclear. My first thought, at least, was
"geez, he's making a HUGE buffer gap", until I started doing the math.
Please just write 16384 or something. It's not like it's a magical
number.
--
(domestic pets only, the antidote for overdose, milk.)
No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html