emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: trunk r113947: * image.c: Fix animation cache signature memory leak.


From: Paul Eggert
Subject: Re: trunk r113947: * image.c: Fix animation cache signature memory leak.
Date: Mon, 19 Aug 2013 09:16:48 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8

Lars Magne Ingebrigtsen wrote:
 
> Seriously?  That's a performance problem?

I did say it was minor.  :-)  I think it's clearer if the code
initializes things just once, but if you think it clearer the other
way please feel free to revert it.

> you didn't test it,
> because it segfaulted the first time it was called.

I did test it, but evidently not with enough test cases.
Sorry about the bug.

To avoid such problems in the future, should we funnel future
image.c changes through you?  Here's a tiny style issue that
should be fixed at some point: the version you inserted has
"strcmp(" in a couple of places where it should be "strcmp (".



reply via email to

[Prev in Thread] Current Thread [Next in Thread]