[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] trunk r114450: * dispnew.c (clear_glyph_row, copy_row_
|
From: |
Dmitry Antipov |
|
Subject: |
Re: [Emacs-diffs] trunk r114450: * dispnew.c (clear_glyph_row, copy_row_except_pointers): |
|
Date: |
Tue, 24 Sep 2013 16:19:35 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
On 9/24/13 12:16 AM, Paul Eggert wrote:
------------------------------------------------------------
revno: 114450
revision-id: address@hidden
parent: address@hidden
committer: Paul Eggert <address@hidden>
branch nick: trunk
timestamp: Tue 2013-09-24 00:16:38 -0700
message:
* dispnew.c (clear_glyph_row, copy_row_except_pointers):
Prefer signed to unsigned integers where either will do.
Since offsetof returns size_t, portable code should not 1) assume
that sizeof (int) == sizeof (size_t) and 2) assume that
offsetof (type, member) is always less than INT_MAX, isn't it?
> Omit easserts with unnecessary and unportable assumptions about
> alignment.
It would be nice to illustrate this thesis with an example of the
architecture/ABI where these assertions doesn't work as expected.
Dmitry