[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] octave.el: Go to error in inferior-octave.
|
From: |
Leo Liu |
|
Subject: |
Re: [PATCH 3/3] octave.el: Go to error in inferior-octave. |
|
Date: |
Fri, 04 Oct 2013 18:04:36 +0800 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.5) |
I have committed the patch to use `compilation-shell-minor-mode' please
give it a try. Thanks.
On 2013-10-03 21:39 +0800, Rüdiger Sonderfeld wrote:
> Oh, I was looking for something like `compilation-shell-minor-mode' yesterday
> but must have missed it. This should probably make patches 1 and 3 obsolete.
>
> But I think patch 2 is still valid. Comint is already having highlight for
> the prompt and adding our own highlight in octave.el is not necessary and
> just
> confusing.
The small prompt font-lock by inferior-octave shouldn't be a problem
because it will have effect only on prompts of past inputs. BTW, seems
stop working that way in trunk.
Leo