|
From: | Dmitry Gutov |
Subject: | Re: [Emacs-diffs] trunk r114556: * test/indent/ruby.rb: Fix a spurious change, add more failing examples. |
Date: | Wed, 09 Oct 2013 06:27:21 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
On 08.10.2013 06:37, Stefan Monnier wrote:
When you're right after the newline that follows the "if" and you call ruby-smie--backward-token do you then get ";" (and move to right after the "if") or do you get "iuwu-mod" (and move to right before the "if")?
The latter.
BTW, I don't guarantee that fixing ruby-smie--implicit-semi-p for this case will give you the intended effect, but without it it'll be difficult to get the intended effect: as it stands, SMIE considers the newline after "if" to terminate the instruction, so the next instruction is of course aligned with the previous one, and changing that in the smie-rules part would invariably break other indentation cases.
Thanks, I think I've fixed that with the change to ruby-smie-rules in 114587.
By the way, could you explain what does the `when' predicate in (:before . "do") rule in ruby-smie-rules do?
If I remove the `when' and just leave (smie-rule-parent), none of the indentation examples break, AFAICS.
[Prev in Thread] | Current Thread | [Next in Thread] |