Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'.

[Daniel Colascione]

On 10/9/13 10:52 AM, Paul Eggert wrote:
> ------------------------------------------------------------
> revno: 114593
> revision-id: address@hidden
> parent: address@hidden
> committer: Paul Eggert <address@hidden>
> branch nick: trunk
> timestamp: Wed 2013-10-09 10:52:38 -0700
> message:
>    * lisp.h (eassert): Don't use 'assume'.
>    
>    Sometimes 'assume' wins in performance, and sometimes it loses,
>    so it shouldn't be used all the time.  Perhaps we need two
>    flavors of 'eassert', one for where 'assume' is far more likely
>    to help or to hurt; but that can be done later.
>    Problem reported by Dmitry Andipov in
>    <http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00276.html>.
>    Also, don't include <verify.h>; no longer needed.

Can you please either 1) restore eassert_and_assume and its callers or 
20 restore the assume calls in alloc.c and data.c? By merging 
eassert_and_assume with eassert, then removing the assume from eassert, 
you've essentially removed calls to assume and pessimized the code.