Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-enc

emacs-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-enc

From:	Bozhidar Batsov
Subject:	Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default.
Date:	Wed, 13 Nov 2013 16:36:43 +0200

I've attached here a second patch that adds support for always inserting a utf-8 encoding comment. I've also simplified a bit the code of `ruby-mode-set-encoding' (by breaking it into several functions) as it was quite convoluted.

On 7 November 2013 13:06, Dmitry Gutov <address@hidden> wrote:

On 07.11.2013 12:23, Bozhidar Batsov wrote:

Btw, Dimitry - please add some info the ruby-mode.el about running the
tests. I tried evaluating and running them manually, but this crashed my
Emacs (the tests hogged my CPU completely and I had to kill Emacs).
Maybe there is something wrong with them right now, or perhaps they
should invoked in some manner I'm not aware of.

I'm not aware of any problems running the tests, looks like a bug. Weren't you able to stop the freezing with C-g, at least?

I just open ruby-mode-tests.el, M-x eval-buffer, M-x ert RET.
They run fine.

0001-lisp-progmodes-ruby-mode.el-ruby-mode-set-encoding.patch
Description: Binary data

[Prev in Thread]

Current Thread

[Next in Thread]

Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., (continued)
- Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Dmitry Gutov, 2013/11/01
  - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Bozhidar Batsov, 2013/11/02
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Dmitry Gutov, 2013/11/02
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Bozhidar Batsov, 2013/11/03
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Dmitry Gutov, 2013/11/03
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Bozhidar Batsov, 2013/11/04
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Bozhidar Batsov, 2013/11/06
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Dmitry Gutov, 2013/11/06
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Bozhidar Batsov, 2013/11/07
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Dmitry Gutov, 2013/11/07
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Bozhidar Batsov <=
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Dmitry Gutov, 2013/11/13
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Bozhidar Batsov, 2013/11/14
    - Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default., Dmitry Gutov, 2013/11/14

Prev by Date: Font display errors in recent emacs
Next by Date: Maximization via -mm (Diff in behaviour)
Previous by thread: Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default.
Next by thread: Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default.
Index(es):
- Date
- Thread