emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r115545: Cleanup cfengine3-mode so complete-symb


From: Stefan Monnier
Subject: Re: [Emacs-diffs] trunk r115545: Cleanup cfengine3-mode so complete-symbol works again.
Date: Mon, 16 Dec 2013 21:25:14 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

>  (defun cfengine3-completion-function ()
>    "Return completions for function name around or before point."
>    (cfengine3-make-syntax-cache)
> -  (let* ((bounds (cfengine3--current-word t))
> +  (let* ((bounds (save-excursion
> +                   (let ((p (point)))
> +                     (skip-syntax-backward "w_" (point-at-bol))
> +                     (list (point) p))))
>           (syntax (cfengine3-make-syntax-cache))
>           (flist (assq 'functions syntax)))

BTW, it would be better for cfengine3-completion-function not to call
cfengine3-make-syntax-cache which can cause all kinds of processing
to happen.  Instead it should return a completion-table-dynamic or
something like that, such that cfengine3-make-syntax-cache is only
called if/when the completion-table is actually used.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]