[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-dynamic-module in Emacs Git?
From: |
Ted Zlatanov |
Subject: |
Re: emacs-dynamic-module in Emacs Git? |
Date: |
Wed, 26 Nov 2014 21:10:31 -0500 |
User-agent: |
Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) |
On Wed, 26 Nov 2014 18:05:55 +0100 Aurélien Aptel <address@hidden> wrote:
AA> On Tue, Nov 25, 2014 at 11:05 AM, Ted Zlatanov <address@hidden> wrote:
>> Push it to your Github repo
>> https://github.com/aaptel/emacs-dynamic-module so it can be reviewed. We
>> will try to get to it quickly and merge it with the necessary ifdefs, if
>> you don't have them.
AA> I've force-pushed on my repo. The branch is "dynamic-modules". It
AA> should already be properly ifdef'd and turned off by default. You can
AA> turn it on via the configure script with --with-ltdl.
I've pushed your dynamic-modules branch (rebased against today's master
branch) to the dynamic-modules branch on the Emacs repo for review and
testing. Please use that in your repo as well.
There are just a few issues, none major:
* two XXX comments
* the ChangeLog entries need rewriting (I would squash to a single
commit anyway, if that's OK with you, which would make the above
rebasing note irrelevant)
* no documentation (NEWS, ELisp manual, etc.)
For me only the first one is a blocker. The documentation is also
important--at least mention how to use this new facility in a text file
please. We can try to write it if you're unable, but it would be good to
give us a first draft at least.
Thanks
Ted
- Re: Network security manager, (continued)
- emacs-dynamic-module in Emacs Git?, Stephen Leake, 2014/11/22
- Re: emacs-dynamic-module in Emacs Git?, Stefan Monnier, 2014/11/22
- Re: emacs-dynamic-module in Emacs Git?, Óscar Fuentes, 2014/11/22
- Re: emacs-dynamic-module in Emacs Git?, Ted Zlatanov, 2014/11/22
- Re: emacs-dynamic-module in Emacs Git?, Aurélien Aptel, 2014/11/23
- Re: emacs-dynamic-module in Emacs Git?, Aurélien Aptel, 2014/11/23
- Re: emacs-dynamic-module in Emacs Git?, Ted Zlatanov, 2014/11/25
- Re: emacs-dynamic-module in Emacs Git?, Aurélien Aptel, 2014/11/26
- Re: emacs-dynamic-module in Emacs Git?,
Ted Zlatanov <=
- Re: emacs-dynamic-module in Emacs Git?, Aurélien Aptel, 2014/11/27
- Re: emacs-dynamic-module in Emacs Git?, Ted Zlatanov, 2014/11/27
- Re: emacs-dynamic-module in Emacs Git?, Eli Zaretskii, 2014/11/29
- Re: emacs-dynamic-module in Emacs Git?, Eli Zaretskii, 2014/11/29
- Re: emacs-dynamic-module in Emacs Git?, Stefan Monnier, 2014/11/30
- Re: emacs-dynamic-module in Emacs Git?, Eli Zaretskii, 2014/11/30
- Re: emacs-dynamic-module in Emacs Git?, Stefan Monnier, 2014/11/30
- Re: emacs-dynamic-module in Emacs Git?, Ted Zlatanov, 2014/11/30
- Re: emacs-dynamic-module in Emacs Git?, Stefan Monnier, 2014/11/30
Re: Network security manager, Eli Zaretskii, 2014/11/17