emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: save-excursion and the mark


From: Oleh Krehel
Subject: Re: save-excursion and the mark
Date: Sun, 19 Apr 2015 17:28:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Hi Stefan,

I finally got around to fixing the lispy tests for emacs-snapshot.

Here's a reference to the first passing build:
https://travis-ci.org/abo-abo/lispy/builds/59129245

And here's the commit that fixed the stuff:
https://github.com/abo-abo/lispy/commit/bf5c12276a414a9cc6a131c86b5c9a33af3dca53

It was also tricky to write code in a way that the tests pass both on 25
and 24.5.

One thing that I really didn't like is that I had to replace

    (region-active-p)

with 

    (and mark-active (not deactivate-mark))

because (region-active-p) started behaving differently in temp buffers
and non-temp buffers. Before, the behavior was the same.

Just my small note to add to the list of "casualties".

Oleh



reply via email to

[Prev in Thread] Current Thread [Next in Thread]