Re: master 89898fc: Repair pdbtrack so it follows transition from one remote file to another.

[Eli Zaretskii]

> From: Ken Manheimer <address@hidden>
> Date: Sun, 20 Sep 2015 11:59:46 -0400
> 
> I am clear that I should remove the ChangeLog.17 entry, and can easily do that
> with an additional, cumulative commit.
> 
> I gather my commit message for the code change should have been:
> 
>     
>     
>     Repair pdbtrack remote file tracking
>     
>     
>     * lisp/progmodes/python.el (python-pdbtrack-set-tracked-buffer): Rectify
>     pdbtrack so it follows transition from one remote file to another.
>     
> 
> I think I am able to `git amend` the original code commit, but I have very
> rarely done that, and am not sure it's the right thing, besides. So: should I
> amend 89898fc, or just do another, distinct commit?

You cannot amend a commit you've already pushed.  Also, the commit
message cannot be fixed by another commit.  What you can do is fix the
entry in ChangeLog.2 produced from that commit log, and then commit
the modified ChangeLog.2.

> Also, I have finally found the location of guidance for commit messages -
> CONTRIBUTORS in the source directory root. I had looked for guidance in
> http://www.emacswiki.org/emacs/GitForEmacsDevs - it would have be helpful if
> that prominently directed contributors to the CONTRIBUTORS file. Perhaps I'm
> just oblivious, but it seems like the various guidance resources are scattered
> enough that there is not an unmissable "garden path" to fill people in.

CONTRIBUTORS is the only reference you should read.