emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: package-install-from-buffer moves point


From: Peter Eisentraut
Subject: Re: package-install-from-buffer moves point
Date: Sat, 7 Nov 2015 13:03:58 -0500
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 7/19/15 1:06 PM, Artur Malabarba wrote:
>>> This is due to calls to some `lm-*' functions inside
>>> `package-buffer-info' (possibly one of the calls I added myself
>>> yesterday). I can just wrap those in save-excursions, but I'm thinking
>>> that the `lm-*' functions themselves should not be moving the point.
>>> Shall I use save-excursion inside those functions instead?
>>
>> Well, there is also a goto-char call right at the top of
>> package-buffer-info.
> 
> Clearly I should stop replying to messages on my phone where I can't
> look at the code first. :)
> 
>> But I agree that the lm-* functions should
>> probably save the point themselves, too.  There are some calls to
>> save-excursion in lisp-mnt.el, but it seems it's not applied consistently.
> 
> Yes. `lm-header' always moves point to the header (besides returning
> it). All the others I looked through seem to be fine.

Did you (or someone) have a chance to work on this?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]