Re: The very latest emacs (25.1.50) segfault

[K. Handa]

In article <address@hidden>, Eli Zaretskii <address@hidden> writes:

> > Date: Mon, 11 Jan 2016 13:57:11 +0900
> > From: Masaru Nomiya <address@hidden>
> > 
> > Program received signal SIGSEGV, Segmentation fault.
> > ftfont_shape_by_flt (matrix=0x3bd67d8, otf=<optimized out>, 
> > ft_face=0x3cbb300, 
> >     font=0x3bd66e0, lgstring=12801653) at ftfont.c:2598
> > 2598          int c1 = LGLYPH_CHAR (LGSTRING_GLYPH (lgstring, 1));
> > (gdb) backtrace
> > #0  ftfont_shape_by_flt (matrix=0x3bd4868, otf=<optimized out>, ft_face=
> >     0x3d37310, font=0x3bd4770, lgstring=12801653) at ftfont.c:2598
> > #1  ftfont_shape (lgstring=12801653) at ftfont.c:2690
> > #2  0x00000000005b0aea in xftfont_shape (lgstring=12801653) at xftfont.c:664
> > #3  0x00000000005608c5 in Ffont_shape_gstring (gstring=12801653) at 
> > font.c:4410
[...]
> Thanks.  Does this happen right when you start Emacs?  Does this
> happen if you start it as "emacs -Q"?

> This looks like a crash in displaying some complex script, so can you
> tell what text was supposed to be displayed?

> Also, if this started happening lately, can you bisect to find the
> commit which exposed this problem?

There's a possibility that my recent change is a culprit.  Please try
to revert this change.

commit 536f48e9a2251b9e654ea974bd90ff2f40218753
Author: K. Handa <address@hidden>
Date:   Sat Jan 2 16:36:21 2016 +0900

    support rendering of wider range of combinging characters by ftfont backend
    
    * lisp/language/hebrew.el (hebrew-shape-gstring): If the font backend
    supports rendering of combining characters, call
    font-shape-gstring.
    
    * src/font.c (Ffont_get): Handle `combining-capability' property.
    (syms_of_font): New symbol ":combining-capability'.
    
    * src/font.h (struct font_driver): New member combining_capability.
    
    * src/ftfont.c: Include "category.h".
    (ftfont_driver): Initialize combining_capability to
    ftfont_combining_capability.
    (ftfont_shape_by_flt): If OTF is null, try to find a suitable
    FLT in advance.
    (ftfont_combining_capability): New function.

---
K. Handa
address@hidden