|
From: | Jussi Lahdenniemi |
Subject: | Re: [PATCH] Override Windows default Win-* key combinations when using Emacs |
Date: | Sat, 16 Jan 2016 13:00:35 +0200 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 16.1.2016 11.58, Eli Zaretskii wrote:
Thanks, I will push these to the emacs-25 branch soon.Done now.
Thanks!
Note one gotcha with calling functions that might not be available at run time: you cannot rely on a static function pointer to be NULL when Emacs starts. That's because when Emacs is dumped, the value of the pointer from the system where Emacs is built is (or could be) recorded in the dumped binary, and is non-NULL. So you must explicitly zero it out every Emacs startup; see the various globals_of_w32* functions which do this for several such pointers. I added a line to reset the resetstkovflw pointer when Emacs starts.
Oh, of course. Didn't think about that. Thanks!
P.S. These patches all but exhaust your grace limit of contributed code we can accept without your assigning copyright, so I hope your legal paperwork is well under way, and we will be able to accept your contributions soon.
My paperwork went into an extra round this week, as I had signed the first set of papers with a date in 2015. I expect the new set to reach FSF during the next week, if the mail is as quick this time as it was with the first set.
-- Jussi Lahdenniemi
[Prev in Thread] | Current Thread | [Next in Thread] |