emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: useless variable handle_user_signal_hook?


From: YAMAMOTO Mitsuharu
Subject: Re: useless variable handle_user_signal_hook?
Date: Thu, 21 Jan 2016 09:43:55 +0900
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI)

>>>>> On Wed, 20 Jan 2016 14:19:39 -0800, Paul Eggert <address@hidden> said:

> The attached patch (recently added to emacs-25) introduced a C
> variable handle_user_signal_hook that is useless because it is
> always null.  Although the variable can be optimized away by
> link-time optimization, typically it is not optimized away.

> Are you intending to add further patches to emacs-25 that need this
> variable, before Emacs 25 is released? If not, how about if we
> remove this variable for now? We can always add it back again later,
> when it's needed.

Feel free to remove it.  It is currently only necessary for the Mac
port.  (Of course, it might be useful if the `select' emulation in
another port wants to get notified when a user signal has arrived.)

                                     YAMAMOTO Mitsuharu
                                address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]