[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region
|
From: |
Lars Ingebrigtsen |
|
Subject: |
Re: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region |
|
Date: |
Sun, 28 Feb 2016 17:21:04 +1100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Mitchel Humpherys <address@hidden> writes:
> On Mon, Feb 22 2016 at 05:04:31 PM, Mitchel Humpherys
> <address@hidden> wrote:
>> Setting a foreground color on the `region' face is slightly annoying.
>> This is subjective, of course, but the consensus among other themes and
>> around the web is to *not* set a foreground color on the region face.
>
> Any objections to this? I should have mentioned that the reason it's
> slightly annoying is because setting a foreground color hides existing
> syntax highlighting within the region text.
The patch sounds OK to me.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no