emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PIXEL_ALREADY_TYPEDEFED


From: Eli Zaretskii
Subject: Re: PIXEL_ALREADY_TYPEDEFED
Date: Tue, 14 Jun 2016 18:11:00 +0300

> Cc: Emacs <address@hidden>
> From: Ken Brown <address@hidden>
> Date: Tue, 14 Jun 2016 10:09:27 -0400
> 
> To get rid of an "unused macro" warning in the Cygwin-w32 build, I want 
> to remove the definition of PIXEL_ALREADY_TYPEDEFED from image.c.  (It's 
> defined in simx.h, which is included by xpm.h, on Cygwin.)  In the 
> course of doing this, I decided to do some cleanup that you suggested in 
> the discussion of bug#18302.  See the attached patch, not yet installed.

Fine with me, it's a Cygwin-only change.

> Question: Should PIXEL_ALREADY_TYPEDEFED be removed unconditionally, or 
> is it needed in the MinGW build?

Deleting it causes no trouble with the version of libXpm headers I
have here (3.5.11), but I hope it won't give trouble to other
versions.  Let's remove it and see if someone hollers.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]