[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Viper tests failure?

From: Eli Zaretskii
Subject: Re: Viper tests failure?
Date: Wed, 22 Jun 2016 19:01:09 +0300

> From: address@hidden (Phillip Lord)
> Cc: address@hidden,  address@hidden
> Date: Tue, 21 Jun 2016 21:26:58 +0100
> > --- a/test/lisp/emulation/viper-tests.el
> > +++ b/test/lisp/emulation/viper-tests.el
> > @@ -38,7 +38,7 @@ viper-test-undo-kmacro
> >          ;; Select an expert-level for the same reason.
> >          (viper-expert-level 5)
> >          ;; viper loads this even with -q so make sure it's empty!
> > -        (viper-custom-file-name (make-temp-file "viper-tests"))
> > +        (viper-custom-file-name (make-temp-file "viper-tests" nil ".elc"))
> >          (before-buffer (current-buffer)))
> >      (unwind-protect
> >          (progn
> Okay, I was wondering whether it was a problem with the suffix.

The final piece of the puzzle is that the code changes the _encoded_
file name, evidently on the assumption that the original file name is
unaffected.  But that assumption is false: when the file name is
all-ASCII, then some file-name encodings (notably, UTF-8) will return
the original Lisp string unaltered, so modifying it will also modify
the original.

> The viper-test is fix obviously fine by me -- should have done it that
> way in the first place, although uncovering the Fload but is a nice side
> effect.

I have now fixed this properly in Fload on master.  No change in
viper-tests is necessary.

> Can you add it to emacs-25

Doesn't sound like a good idea: the changes are not really trivial,
and this problem has been with us for so long that one more release is
not an issue.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]