Re: Somwhat subtle issues with raw string literals in C++

[Alan Mackenzie]

Hello, Philipp

On Thu, Jun 30, 2016 at 11:35:27AM +0000, Philipp Stephani wrote:
> Alan Mackenzie <address@hidden> schrieb am Do., 30. Juni 2016 um 07:59 Uhr:

> > Hello again, Philipp,

> > On Tue, Jun 28, 2016 at 03:33:30PM +0000, Philipp Stephani wrote:
> > > Hi,

> > > there still seem to be some subtle issues with detection of raw string
> > > literals. Unfortunately they are hard to reproduce. One example that
> > fails
> > > (for me) with a recent master build is:

> > > cd /tmp
> > > wget

> > https://raw.githubusercontent.com/google/protobuf/ef7894e2dc6d287419e42a4fdc52cdfedd386d16/conformance/conformance_test.cc
> > > /path/to/emacs -Q +686 conformance_test.cc

> > > Around that line the fontification of the raw string literals is wrong
> > > (quote characters are treated as string terminators), in other parts of
> > the
> > > file the fontification is correct. This typically happens with files that
> > > contain many large raw string literals that contain quote characters.

> > Again, thanks for the report.

> > The problem was a mishandling of a cache, with the result that the raw
> > string handling code mistakenly believed it was within a string when it
> > wasn't, at a critical point in the file.

> > Would you please try out the following patch and confirm that it fixes
> > the problem, or let me know what's still not working properly.


> At least in the case I tested, the patch appears to fix the problem. Thanks
> a lot for the quick fix.

Thank you again for the report.  I've committed the patch to the Emacs
master branch.

-- 
Alan Mackenzie (Nuremberg, Germany).