emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bisecting display bugs


From: Clément Pit--Claudel
Subject: Re: Bisecting display bugs
Date: Sat, 23 Jul 2016 09:22:12 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 2016-07-23 04:51, Eli Zaretskii wrote:
>> Cc: Emacs developers <address@hidden>
>> From: Clément Pit--Claudel <address@hidden>
>> Date: Fri, 22 Jul 2016 14:55:36 -0400
>>
>> Thanks for your comments! I've attached an updated patch.
> 
> LGTM, thanks.  One comment:
> 
>> +- You should produce the ‘../reproduce-your-bug.el’ script on your own
>> +  (it should check if the bug exists, and return the right error code
>> +  using ‘(kill-emacs EXIT-CODE)’).
> 
> Suggest to say explicitly what is "the right error code" (yes, that
> means repeating what you said just 20 lines above, but the relation is
> not 100% clear).

Thanks; here's a diff against the previous patch (I've attached the updated 
patch). I also added a note about full rebuilds.

---
 
Some caveats:

-  make sure your uncommitted changes are saved somewhere else.
+  make sure your uncommitted changes are saved somewhere else.  Also,
+  for bisecting small ranges, a full clean and rebuild might not be
+  needed.
 
-  using ‘(kill-emacs EXIT-CODE)’).
+  using ‘(kill-emacs EXIT-CODE)’: 1 if the bug is present, 0 if it is
+  not, and 125 if it can't tell).

---

Attachment: 0001-Add-notes-about-using-git-bisect-to-pinpoint-Emacs-b.patch
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]