emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enable customisation for electric-quote-mode chars


From: Paul Eggert
Subject: Re: [PATCH] Enable customisation for electric-quote-mode chars
Date: Sun, 28 Aug 2016 18:55:06 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

Göktuğ Kayaalp wrote:

I guess the build system should require a certain
minimum version for the texinfo compiler

It's a bit tricky as we don't want to require texinfo for ordinary installs. Probably worth documenting for Git builds, though. I added the attached.

the default texinfo 4.8 on my FreeBSD 10.3,

4.8 is pretty old; I don't think we want to bother with porting to it.

(all okay when I installed 6.1 from ports)

Yes, that's the way to go.

As for the patch itself:

* Part of the code still assumes English-style single quoting, and won't work if electric-quote-chars is set appropriately for (say) French. Look for instances of the two characters ‘ and ’ in the string constants. More generally, I'd look for any non-ASCII character in that file.

* The documentation should say "curved" rather than "curvy" for consistency with what's there now.

* The documentation is a bit sloppy about which quotes are used for what, e.g., "the first two are used for left single quotes" is not correct and the doc string is a bit hard to follow. For the documentation I suggest specifying the default value in the manual, as that should make it easier to explain the format of the variable.

* Perhaps use pcase instead of 4 calls to nth? It'd make the code easier to 
read.

* Finally, it's a nontrivial patch so I assume you're OK with assigning copyright to the FSF? If so, I can start the ball rolling on the paperwork for you.

Thanks again.

Attachment: 0001-INSTALL.REPO-Suggest-Texinfo-4.13-or-later.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]