Re: emacsclient in 25 branch: error opening any file

[Noam Postavsky]

On Mon, Nov 28, 2016 at 1:46 PM, Joseph Mingrone <address@hidden> wrote:
> Joel Rosdahl (address@hidden) has done some detective work:
>> Here's how to reproduce (at least my version of) the problem:
>
>> emacs -q --daemon
>> emacsclient -nc
>> In Emacs: C-s                         ; enter isearch-mode
>> emacsclient -e '(find-file ".")'
>> In Emacs: C-x b RET
>> emacsclient .
>
>> What seems to happen is that isearch-mode can be left in a bad state after
>> using "emacsclient -e", and then server-goto-toplevel tries to perform
>> isearch-cancel on the buffer, which fails since isearch--current-buffer is
>> nil (while isearch-mode is non-nil).
>
>> This part of isearch-done seems to have been added to Emacs 25, and that's
>> what fails when isearch--current-buffer is nil:
>
>> (with-current-buffer isearch--current-buffer
>>   (setq isearch--current-buffer nil)
>>   (setq cursor-sensor-inhibit (delq 'isearch cursor-sensor-inhibit)))

isearch-done in the current emacs-25 branch checks that
isearch--current-buffer is a live buffer, see also
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21091

Not sure if having isearch--current-buffer be nil in this case is
actually an additional bug.