Re: [Emacs-diffs] master a2ee819: Let delete-selection-mode work with popup-menu commands (Bug#27569)

[Noam Postavsky]

On Tue, Jul 18, 2017 at 9:41 AM, Stefan Monnier
<address@hidden> wrote:
>> +      ;; Update `this-command' and run `pre-command-hook' so that
>> +      ;; things like `delete-selection-pre-hook' will work correctly.
>> +      (setq this-command cmd)
>> +      (run-hooks 'pre-command-hook)
>>        ;; mouse-major-mode-menu was using `command-execute' instead.
>>        (call-interactively cmd))))
>
> Hmm... shouldn't it then also run post-command-hook, and set
> last-command (and probably a few more of the things done in the usual
> command loop, such as handling undo-boundaries)?

I'm not sure, won't we end up with 1 1/2 of the command stuff done in
that case? (the half being the popup-menu we began executing to get
here).