[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 885c512: Fix a bug in 'generate-new-buffer-name
Re: [Emacs-diffs] master 885c512: Fix a bug in 'generate-new-buffer-name'
Sat, 05 Aug 2017 18:58:37 +0300
> From: Stefan Monnier <address@hidden>
> Cc: address@hidden
> Date: Sat, 05 Aug 2017 11:14:30 -0400
> >> > - if (!NILP (Fstring_equal (name, ignore)) || NILP (Fget_buffer (name)))
> >> > + if ((!NILP (ignore) && !NILP (Fstring_equal (name, ignore)))
> >> > + || NILP (Fget_buffer (name)))
> >> Why not just use Fequal instead of Fstring_equal?
> > Because no one said that using a symbol for the IGNORE argument is
> > forbidden in that function. "nil" just happens to be a special case,
> > but other strings/symbols are allowed.
> I'd be surprised if there is code out there that uses a symbol for the
> `ignore` argument. And I don't think it's a feature that you can use
> a symbol rather than a string. I think it's rather a (harmless (except
> for nil)) bug.
Maybe so, but I see no real reason to switch to using Fequal, either.