[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-26, make check failures, mingw64
From: |
Eli Zaretskii |
Subject: |
Re: emacs-26, make check failures, mingw64 |
Date: |
Wed, 20 Sep 2017 10:21:06 +0300 |
> From: Paul Eggert <address@hidden>
> Date: Tue, 19 Sep 2017 12:38:46 -0700
>
> On 09/19/2017 12:08 PM, Fabrice Popineau wrote:
> > Clearly, the timezone is wrongly formatted.
>
> This is because src/w32.c uses the abbreviation "ZZZ" when a POSIX TZ
> abbreviation is not supported by MS-Windows.
>
> One possible fix would be for src/w32.c to call tzset with a ZZZ...Z
> abbreviation, and then to modify tzname[0] afterwards to have a copy of
> the POSIX-specified abbreviation. src/w32.c could use enough Zs so that
> the tzname[0] created by the MS-Windows library would be long enough and
> could be updated in place rather than worrying about our reallocating it.
>
> If that's too much trouble, another workaround would be to change the
> test case so that it is not run on MS-Windows.
I just tweaked the test to match what Windows returns in this case.
The main purpose of the test, AFAIU, is not to test the correctness of
the time-zone translation, and there's nothing wrong in ZZZ given that
the "-08" thing is not supported on Windows. The rest of the result
is correct, so making non-trivial changes in tzset/tzname sounds too
much trouble for very little gain: code should not generally be
tweaked to fix failing tests with fictitious values.
Thanks.
- emacs-26, make check failures, mingw64, Fabrice Popineau, 2017/09/19
- Re: emacs-26, make check failures, mingw64, Paul Eggert, 2017/09/19
- Re: emacs-26, make check failures, mingw64,
Eli Zaretskii <=
- Re: emacs-26, make check failures, mingw64, Eli Zaretskii, 2017/09/20