[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adding new variable for face-list in internal-make-lisp-face.
From: |
Eli Zaretskii |
Subject: |
Re: Adding new variable for face-list in internal-make-lisp-face. |
Date: |
Fri, 03 Nov 2017 12:17:05 +0200 |
> Date: Thu, 02 Nov 2017 20:50:47 -0700
> From: Keith David Bershatsky <address@hidden>
>
> In implementing feature requests crosshairs (17684) and multiple fake cursors
> (22873), I thought it would be nifty to identify the background color (if
> applicable) associated with a tab ('\t') glyph code in the
> buffer-display-table. In doing so, I discovered that the Lisp function
> face-list is way too slow. Even after I ported the face-list function over
> to C, it was still way too slow. So, I tried my luck at adding a new
> variable in xfaces.c for the face-list and am setting it from within the
> function internal-make-lisp-face, like so:
I don't understand why you need face-list for this. For each glyph in
the display table, you get its face ID by using the GLYPH_FACE macro.
Why isn't that sufficient for your needs?