[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: What's the right way to detect libxml2?
From: |
Robert Pluim |
Subject: |
Re: What's the right way to detect libxml2? |
Date: |
Fri, 03 Nov 2017 18:17:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
>> From: Robert Pluim <address@hidden>
>> Cc: address@hidden, address@hidden
>> Date: Mon, 30 Oct 2017 09:49:45 +0100
>>
>> > This is okay for the master branch, but please also add a NEWS entry
>> > about the new function, and the fact that from now on the detection of
>> > libxml2 availability should use that.
>>
>> Attached, as I don't have commit privileges, and I don't know whether
>> my copyright assignment has finished being processed yet.
>
> Thanks, pushed to the master branch.
>
> A comment for the future: please always end the log en tries with a
> period, to make them complete sentences. Like this:
>
> * src/xml.c (Flibxml_available_p): New function, cloned from
> Fgnutls_available_p.
> (syms_of_xml): Provide Slibxml_available_p.
I tend to use the full stop as a separator rather than a terminator,
but I'll adjust for Emacs.
Robert