emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there'


From: Paul Eggert
Subject: Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961)
Date: Fri, 15 Dec 2017 11:09:32 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 12/15/2017 10:17 AM, martin rudalics wrote:
How did you recognize the "callers that have the
assumption"?  What about the call in check_glyph_memory?

I recognized callers that either --enable-gcc-warnings complained about (because code after the FOR_EACH_FRAME loop clearly had undefined behavior unless the loop iterated at least once), and callers where historically there was an eassert that checked the assumption. check_glyph_memory doesn't fall into either category; and now that I look at its implementation it's clear that check_glyph_memory is not making the assumption.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]