emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: git history tracking across renames (and emacs support) (Was: The na


From: Paul Eggert
Subject: Re: git history tracking across renames (and emacs support) (Was: The name gnus-cloud.el)
Date: Mon, 8 Jan 2018 10:41:34 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 01/08/2018 10:30 AM, Eli Zaretskii wrote:
there's no need to explain why a certain variable is static.
Sometimes there is, sometimes there isn't. If it's important enough to mention the change from extern to static in the commit message, the current guidelines would seem to imply that it's important enough to mention why the change was made in code comments.

Another possibility would be to say that trivial changes like this one (where the change and its intent are obvious-enough from the diff) don't need to be mentioned in the ChangeLog. That would be OK.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]