Re: kqueue.c and <sys/file.h>

[Jeremie Courreges-Anglas]

On Sat, Jan 13 2018, Michael Albinus <address@hidden> wrote:
> Michael Albinus <address@hidden> writes:
>
> Hi Jeremie,

Hi,

>>> While sys/file.h has been around since some time now, it is not part of
>>> the POSIX standard (or any standard that I know of), and it looks like
>>> most of its consumers really want to include <fcntl.h> instead to access
>>> the various O_* #defines used by open(2).
>>>
>>> Within Emacs, src/kqueue.c seems to be the only source file that depends
>>> on sys/file.h to build on OpenBSD.  As discussed with Michael Albinus,
>>> I'd suggest using fcntl.h there (trivial diff below).  I guess it should
>>> be tested on other systems that provide kqueue(2) (*BSD, OSX, ?) but
>>> I don't expect fallout.
>>
>> Thanks for this! Pls provide also a ChangeLog entry with reasoning for
>> this patch.
>>
>> Let's wait a week or so. If nobody complains, I'll commit the patch to
>> the master branch then, in your name.
>
> Nobody has complained, so the patch will be applied. Could you pls send
> me the ChangeLog entry with reasoning?

Here is a patch.

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

0001-Prefer-fcntl.h-to-sys-file.h.patch
Description: Text Data

signature.asc
Description: PGP signature