[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/
From: |
Thien-Thi Nguyen |
Subject: |
Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/U-pattern/g’, ‘s/QPattern/Q-pattern/g’ |
Date: |
Sun, 13 May 2018 19:46:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
() Stefan Monnier <address@hidden>
() Sat, 12 May 2018 11:01:16 -0400
Hmm... I think this text should be changed to use the term
"pattern" for "U(-)pattern".
I've come around to this pov as well. See latest commits.
WRT Q-pattern:
My understanding is that `QPAT is an "extension" in deed (since
it's implemented via ‘pcase-defmacro’), but perhaps "innate" in
spirit. I moved the "structural pattern" stuff to the
(pcase-defmacro \` (qpat) ...)
docstring and added a comment in ‘pcase--make-docstring’ (but
have not changed any code). I think if we can get `QPAT to be
first in the extensions docs (in *Help*), this would satisfy
both the maintainability best practice (keep documentation near
its code) and the user experience best practice (good flow,
ordering).
What do people think?
--
Thien-Thi Nguyen -----------------------------------------------
(defun responsep (query)
(pcase (context query)
(`(technical ,ml) (correctp ml))
...)) 748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502
signature.asc
Description: PGP signature
- Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/U-pattern/g’, ‘s/QPattern/Q-pattern/g’, Stefan Monnier, 2018/05/12
- Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/U-pattern/g’, ‘s/QPattern/Q-pattern/g’,
Thien-Thi Nguyen <=
- Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/U-pattern/g’, ‘s/QPattern/Q-pattern/g’, Michael Heerdegen, 2018/05/15
- Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/U-pattern/g’, ‘s/QPattern/Q-pattern/g’, Stefan Monnier, 2018/05/15
- Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/U-pattern/g’, ‘s/QPattern/Q-pattern/g’, Thien-Thi Nguyen, 2018/05/18
- Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/U-pattern/g’, ‘s/QPattern/Q-pattern/g’, Stefan Monnier, 2018/05/18
- Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/U-pattern/g’, ‘s/QPattern/Q-pattern/g’, Thien-Thi Nguyen, 2018/05/18
- Re: [Emacs-diffs] fix/bug-3133-pcase-doc 1181796 01/13: do ‘s/UPattern/U-pattern/g’, ‘s/QPattern/Q-pattern/g’, Stefan Monnier, 2018/05/18