[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-26 eec71eb: Speed up replace-buffer-contents

From: Paul Eggert
Subject: Re: emacs-26 eec71eb: Speed up replace-buffer-contents
Date: Sat, 7 Jul 2018 11:22:33 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

Eli Zaretskii wrote:
Profiling the optimized build shows that 60% of the time is spent
inside buffer_chars_equal, and another 26% inside compareseq.
rarely_quit and maybe_quit are nowhere in sight in the profile.

That's what I would expect: rarely_quit is inlined, so you don't see it in the profile (even though it's there and has some cost), and maybe_quit is called so rarely that you don't see it in the profile.

So I think we have no performance problem we need to fix, right?

It sounds like we never had a performance problem in optimized builds that we needed to fix. I.e., the recent patch was needed only for unoptimized builds. Which is unfortunate, as we shouldn't have to hand-optimize unoptimized builds. I'll keep that in mind if I ever find time to look into the performance problem.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]