Re: netsec 682578f 4/6: Add option to bypass NSM TLS checks on local networks

[Eli Zaretskii]

> From: Jimmy Yuen Ho Wong <address@hidden>
> Date: Mon, 16 Jul 2018 16:24:45 +0100
> Cc: Robert Pluim <address@hidden>, Emacs-Devel devel <address@hidden>
> 
> > > +  ret = getaddrinfo (SSDATA (name), NULL, &hints, &res);
> >
> > You should encode NAME (using ENCODE_SYSTEM), because it could include
> > non-ASCII characters.  In general, any Lisp string should be encoded
> > before you can pass its data to a C library function.
> >
> 
> Does getaddrinfo accept unicode hostnames? If not I think we can just
> make sure NAME is all ASCII as per Punycode for i18nized host names.

That's fine with me, but my point is that simply plugging the string
data into a libc function is usually not OK.