emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New warnings on emacs-26 branch with gcc 8.2.0


From: Andy Moreton
Subject: Re: New warnings on emacs-26 branch with gcc 8.2.0
Date: Fri, 17 Aug 2018 22:33:40 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt)

On Fri 17 Aug 2018, Eli Zaretskii wrote:

>> From: Andy Moreton <address@hidden>
>> Date: Fri, 17 Aug 2018 16:21:24 +0100
>> 
>> >> C:/emacs/git/emacs/master/src/w32fns.c: In function 'Fw32_read_registry':
>> >> C:/emacs/git/emacs/master/src/w32fns.c:10142:21: warning: 'rootkey' may 
>> >> be used uninitialized in this function [-Wmaybe-uninitialized]
>> >>    Lisp_Object val = w32_read_registry (NILP (root)
>> >>                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> >>             ? HKEY_CURRENT_USER
>> >>             ~~~~~~~~~~~~~~~~~~~
>> >>             : rootkey,
>> >>             ~~~~~~~~~~
>> >>             key, name);
>> >>             ~~~~~~~~~~
>> >
>> > Thanks, pushed to the master branch.  I just made the new function's
>> > name a bit shorter.
>> 
>> Thanks. The warning shown above can be fixed with this patch:
>
> Thanks, but I prefer using UNINIT only where no better solution is at
> hand.  In this case, there is; please try the patch below:

Yes, your patch is a better fix (and fixes the warning).

Thanks,

    AndyM




reply via email to

[Prev in Thread] Current Thread [Next in Thread]