[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tramp and fixnum (was: Making 'eq' == 'eql' in bignum branch)
From: |
Eli Zaretskii |
Subject: |
Re: Tramp and fixnum (was: Making 'eq' == 'eql' in bignum branch) |
Date: |
Sun, 26 Aug 2018 19:06:54 +0300 |
> From: Paul Eggert <address@hidden>
> Date: Sun, 26 Aug 2018 08:34:25 -0700
> Cc: address@hidden
>
> > What do you mean with `list-attributes'? Maybe `file-attributes'?
>
> Yes, sorry, I meant 'file-attributes'. The fishy-looking code is in
> tramp-convert-file-attributes. Here's one snippet:
>
> (when (and (floatp (nth 2 attr))
> (<= (nth 2 attr) most-positive-fixnum))
> (setcar (nthcdr 2 attr) (round (nth 2 attr))))
>
> Although this snippet shouldn't hurt, it should be unnecessary once
> file-attributes is fixed to not return floats.
Fixed in what version of Emacs? Tramp wants to support more than just
the latest master version.
> The main offender is the inode converter in that function, which splits
> integers
> into three parts, whereas it should simply keep the integers as-is since they
> don't overflow any more.
They do in older Emacs versions, AFAIR.
- Re: Making 'eq' == 'eql' in bignum branch, (continued)
- Re: Making 'eq' == 'eql' in bignum branch, Eli Zaretskii, 2018/08/20
- Re: Making 'eq' == 'eql' in bignum branch, Richard Stallman, 2018/08/20
- Re: Making 'eq' == 'eql' in bignum branch, Eli Zaretskii, 2018/08/20
- Re: Making 'eq' == 'eql' in bignum branch, Lars Ingebrigtsen, 2018/08/20
- Re: Making 'eq' == 'eql' in bignum branch, Eli Zaretskii, 2018/08/20
- Re: Making 'eq' == 'eql' in bignum branch, Stefan Monnier, 2018/08/22
- Re: Making 'eq' == 'eql' in bignum branch, Richard Stallman, 2018/08/20
- Re: Making 'eq' == 'eql' in bignum branch, Paul Eggert, 2018/08/25
- Tramp and fixnum (was: Making 'eq' == 'eql' in bignum branch), Michael Albinus, 2018/08/26
- Re: Tramp and fixnum (was: Making 'eq' == 'eql' in bignum branch), Paul Eggert, 2018/08/26
- Re: Tramp and fixnum (was: Making 'eq' == 'eql' in bignum branch),
Eli Zaretskii <=
- Re: Tramp and fixnum, Michael Albinus, 2018/08/26
- Re: Tramp and fixnum (was: Making 'eq' == 'eql' in bignum branch), Paul Eggert, 2018/08/28
- Re: Tramp and fixnum, Michael Albinus, 2018/08/26
- Re: Tramp and fixnum, Paul Eggert, 2018/08/28
- Re: Tramp and fixnum, Michael Albinus, 2018/08/28
- Re: Tramp and fixnum, Michael Albinus, 2018/08/28
- Re: Tramp and fixnum, Paul Eggert, 2018/08/28
- Re: Tramp and fixnum, Michael Albinus, 2018/08/29
- Re: Making 'eq' == 'eql' in bignum branch, Tom Tromey, 2018/08/26
- Re: Making 'eq' == 'eql' in bignum branch, Stefan Monnier, 2018/08/26