[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Window tree and window's internal height

From: Eli Zaretskii
Subject: Re: Window tree and window's internal height
Date: Mon, 19 Nov 2018 20:36:24 +0200

> Date: Mon, 19 Nov 2018 10:41:03 +0100
> From: martin rudalics <address@hidden>
> CC: address@hidden
>  > I thought of saying something like
>  >
>  >    The minibuffer window does not have a parent window, but it
>  >    nevertheless is a sibling of the frame's root window, and thus can
>  >    be reached via window-next-sibling.
> I'd start the sentence with "A minibuffer window that is not alone on
> its frame ..." but for the rest it's fine with me.

Thanks, I used that.

>  > I don't.  I've read the description of the window tree, and thought
>  > "this is a single window on its TTY frame, it cannot possibly have
>  > anything non-nil pointed to by its 'next' pointer".  Oops!
> So sometimes such details are important in the manual.  Still, I
> wouldn't rely on the Elisp manual to tell me anything about the
> underlying C structures.

Well, I turned to the manual after becoming disappointed in the
comments to 'struct window' definition...

>  > No.  The code is very unequivocal:
>  >
>  >    /* If we must, use the pixel-based version which is much slower than
>  >       the line-based one but can handle varying line heights.  */
>  >    if (FRAME_WINDOW_P (XFRAME (XWINDOW (window)->frame)))  <<<<<<<<<<
>  >      window_scroll_pixel_based (window, n, whole, noerror);
>  >    else
>  >      window_scroll_line_based (window, n, whole, noerror);
> The code is unequivocal, the comment leaves much room to
> interpretation.

I made it more clear now.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]