Re: macOS fullscreen crashes

[Alan Third]

On Sat, Dec 01, 2018 at 03:45:57PM +0100, Charles A. Roelli wrote:
> > Date: Sat, 1 Dec 2018 13:18:51 +0000
> > From: Alan Third <address@hidden>
> >
> > BTW, it looks like there are two different sets of macros for this,
> > there are the ones we’re using, and newer ones defined in
> > Availability.h that have two underscores at the start. It looks like
> > the newer ones are a bit neater. If you use
> > 
> >     -mmacosx-version-min=10.x
> > 
> > it disables a great many deprecation warnings that you get if you just
> > set MAC_OS_X_VERSION_MIN_REQUIRED like we do.
> > 
> > I don’t think we should be changing anything at the moment, and I
> > don’t know if those macros are available on macOS 10.6 so they may not
> > be much use to us, but it is nice how it makes the compiler output a
> > lot quieter.
> 
> __MAC_OS_X_VERSION_MIN_REQUIRED and __MAC_OS_X_VERSION_MAX_ALLOWED are
> available in 10.6 (and the use of, e.g. -mmacosx-version-min=10.x, is
> recommended in Availability.h).  But it's unlikely that FSF GCC would
> support the "-mmacosx-version-min" flag, so we may not be able to use
> it.

Good to know. Doessetting __MAC_OS_X_VERSION_MIN_REQUIRED directly
work just as well?

> Thanks, this looks good.  We should also mention in NEWS that this is
> a change in build behavior from previous Emacs versions (and that this
> change was originally made in Emacs 26.1 but not mentioned in its NEWS).

I’m not sure that there’s any reason to mention that it was available
in 26.1 but undocumented. Is that standard practice?

Anyway, patch attached.
-- 
Alan Third

0001-Add-notes-about-cross-compiling-macOS-versions.patch
Description: Text document